Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only] increase coverage test for creating space #5616

Merged
merged 2 commits into from
Feb 22, 2023
Merged

[test-only] increase coverage test for creating space #5616

merged 2 commits into from
Feb 22, 2023

Conversation

ScharfViktor
Copy link
Contributor

I added tests for:

  • creating space with different role
  • getting space by id

@update-docs
Copy link

update-docs bot commented Feb 21, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor requested a review from saw-jan February 22, 2023 08:00
@ownclouders
Copy link
Contributor

💥 Acceptance test wopiValidatorTests-ocis failed. Further test are cancelled...

SagarGi
SagarGi reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@individual-it individual-it merged commit 5a5e950 into master Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the increaseTestCreatingSpace branch February 22, 2023 09:09
ownclouders pushed a commit that referenced this pull request Feb 22, 2023
@ScharfViktor
commit 5a5e950
51a4d6f 
Author: Viktor Scharf <[email protected]>
Date:   Wed Feb 22 10:09:19 2023 +0100

    [test-only] increase coverage test for creating space (#5616)
ScharfViktor added a commit that referenced this pull request Feb 22, 2023
@ScharfViktor
[test-only] increase coverage test for creating space (#5616)
fa06c09
@ScharfViktor ScharfViktor mentioned this pull request Feb 22, 2023
Merged
individual-it added a commit that referenced this pull request Feb 23, 2023
@individual-it
Merge pull request #5630 from owncloud/port#5616
a04ce72 
[test-only] increase coverage test for creating space (#5616)
ownclouders pushed a commit that referenced this pull request Feb 23, 2023
@individual-it
commit a04ce72
e507488 
Merge: 515f4c4 fa06c09
Author: Artur Neumann <[email protected]>
Date:   Thu Feb 23 12:11:50 2023 +0545

    Merge pull request #5630 from owncloud/port#5616

    [test-only] increase coverage test for creating space (#5616)
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@individual-it individual-it individual-it approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScharfViktor @ownclouders @individual-it @SagarGi @saw-jan