Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Remove scenarios tagged skiponocis #5520

Merged
merged 3 commits into from
Feb 21, 2023
Merged

[full-ci] [tests-only] Remove scenarios tagged skiponocis #5520

merged 3 commits into from
Feb 21, 2023

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Feb 7, 2023 •
edited
Loading

Description

This PR removes @skipOnOcis tagged scenarios from ocis.
We cannot set Sharing settings in ocis #1328.

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup self-assigned this Feb 7, 2023
@grgprarup
Copy link
Contributor Author

  • Forward port to master

@grgprarup grgprarup mentioned this pull request Feb 7, 2023
Closed
57 tasks
@grgprarup grgprarup force-pushed the remove-scenarios-tagged-skiponocis branch from 047d47f to c6e0235 Compare February 15, 2023 07:04
@grgprarup grgprarup force-pushed the remove-scenarios-tagged-skiponocis branch 3 times, most recently from 86fb894 to 716868a Compare February 20, 2023 08:32
@grgprarup grgprarup force-pushed the remove-scenarios-tagged-skiponocis branch from 716868a to 8c1803e Compare February 20, 2023 08:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grgprarup grgprarup marked this pull request as ready for review February 20, 2023 09:13
@phil-davis
Copy link
Contributor

https://github.com/owncloud/ocis/tree/remove-scenarios-tagged-skiponocis
"This branch is 128 commits ahead, 583 commits behind master."

That is a bit scary. Please rebase to get really up-to-date CI. I don't want to merge this and then find that there is some unexpected problem.

@grgprarup
Copy link
Contributor Author

https://github.com/owncloud/ocis/tree/remove-scenarios-tagged-skiponocis "This branch is 128 commits ahead, 583 commits behind master."

That is a bit scary. Please rebase to get really up-to-date CI. I don't want to merge this and then find that there is some unexpected problem.

I will make forward port pr to the master branch.

@phil-davis
Copy link
Contributor

Oh, I forgot that this is to stable-2.0 branch, sorry. The message about being behind is not relevant.

SagarGi
SagarGi reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis phil-davis merged commit 6815cba into stable-2.0 Feb 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove-scenarios-tagged-skiponocis branch February 21, 2023 08:18
ownclouders pushed a commit that referenced this pull request Feb 21, 2023
@phil-davis
commit 6815cba
f5ad17d 
Merge: fe490fd 8c1803e
Author: Phil Davis <[email protected]>
Date:   Tue Feb 21 14:03:51 2023 +0545

    Merge pull request #5520 from owncloud/remove-scenarios-tagged-skiponocis

    [full-ci] [tests-only] Remove scenarios tagged skiponocis
@grgprarup grgprarup mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis phil-davis approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

@micbar micbar Awaiting requested review from micbar

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grgprarup @phil-davis @individual-it @SagarGi