Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Forward-port Refactor share permission related scenario #5508

Merged
merged 1 commit into from
Feb 7, 2023
Merged

[tests-only][full-ci]Forward-port Refactor share permission related scenario #5508

merged 1 commit into from
Feb 7, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR forward-port refactor related to share-permission

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Feb 3, 2023
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 3, 2023
Closed
2 tasks
saw-jan
saw-jan reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

SagarGi
SagarGi reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if CI is happy

@amrita-shrestha amrita-shrestha force-pushed the forward-port-refactor-share-permission-coreApiSharePublicLink2 branch from 284af80 to 66b6389 Compare February 7, 2023 15:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha merged commit 0e5d0cb into master Feb 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the forward-port-refactor-share-permission-coreApiSharePublicLink2 branch February 7, 2023 16:19
ownclouders pushed a commit that referenced this pull request Feb 7, 2023
@amrita-shrestha
commit 0e5d0cb
976666a 
Merge: 49d7049 66b6389
Author: Amrita <[email protected]>
Date:   Tue Feb 7 22:04:46 2023 +0545

    Merge pull request #5508 from owncloud/forward-port-refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Forward-port Refactor share permission related scenario
ownclouders pushed a commit that referenced this pull request Feb 8, 2023
@amrita-shrestha
commit 0e5d0cb
c554e28 
Merge: 49d7049 66b6389
Author: Amrita <[email protected]>
Date:   Tue Feb 7 22:04:46 2023 +0545

    Merge pull request #5508 from owncloud/forward-port-refactor-share-permission-coreApiSharePublicLink2

    [tests-only][full-ci]Forward-port Refactor share permission related scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amrita-shrestha @SwikritiT @SagarGi @saw-jan