Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Configuration for Postprocessing Service #5457

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Better Configuration for Postprocessing Service #5457

merged 4 commits into from
Jan 26, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jan 25, 2023

Allows configuring the postprocessing service via the POSTPROCESSING_STEPS envvar

@kobergj
Copy link
Collaborator Author

kobergj commented Jan 25, 2023

@mmattel any chance you can do your magic with this PR? 😄

@ownclouders
Copy link
Contributor

ownclouders commented Jan 25, 2023 •
edited
Loading

💥 Acceptance test wopiValidatorTests-ocis failed. Further test are cancelled...

@kobergj kobergj requested a review from mmattel January 25, 2023 14:48
@kobergj @mmattel
update wording
9c0dd22 
Co-authored-by: Martin <[email protected]>
@kobergj kobergj force-pushed the PostprocessingConfiguration branch from 94fe231 to 161dfb0 Compare January 26, 2023 09:26
@kobergj kobergj force-pushed the PostprocessingConfiguration branch from 8929073 to d468a23 Compare January 26, 2023 10:50
mmattel
mmattel approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

butonic
butonic suggested changes Jan 26, 2023
View reviewed changes
Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move config validation to the parser package

@kobergj kobergj requested a review from butonic January 26, 2023 13:46
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kobergj kobergj merged commit ebd55eb into owncloud:master Jan 26, 2023
@kobergj kobergj deleted the PostprocessingConfiguration branch January 26, 2023 14:23
ownclouders pushed a commit that referenced this pull request Jan 26, 2023
@kobergj
commit ebd55eb
5ffc415 
Merge: aa12a60 ab4d8c3
Author: kobergj <[email protected]>
Date:   Thu Jan 26 15:23:19 2023 +0100

    Merge pull request #5457 from kobergj/PostprocessingConfiguration

    Better Configuration for Postprocessing Service
@mmattel mmattel mentioned this pull request Jan 27, 2023
Merged
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel approved these changes

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobergj @ownclouders @butonic @mmattel