[test-only][full-ci] ApiTest. creating a shared resource with an expiration date #5424

ScharfViktor · 2023-01-18T17:50:21Z

changed tests shareSubItemOfSpace.feature add ability to set expire date
refactoring code
deleted core test
created test share to group
test for change expiration date
created bug Sharing to a group with an expiration date does not work #5442
test where user shares to group and to user with different role and expiration date. I haven't idea what should I expect in the GET https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares/shareId response

update-docs · 2023-01-18T17:50:24Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

ownclouders · 2023-01-18T17:59:59Z

💥 Acceptance test Core-API-Tests-ocis-storage-4 failed. Further test are cancelled...

saw-jan

Indentation only

tests/acceptance/features/apiSpacesShares/copySpaces.feature

tests/acceptance/features/bootstrap/Sharing.php

tests/acceptance/features/apiSpacesShares/shareSubItemOfSpace.feature

ScharfViktor · 2023-01-23T16:23:51Z

when creating the test, I noticed a difference in the expiration date between share and share public link
https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/bootstrap/Sharing.php#L1292-L1296

method isFieldInResponse cannot work for share фтв public link because expects date in format: 2023-01-31 22:59:59

actual expiration date in response
share: <expiration>2023-01-31T23:59:59+0100</expiration>
public link: <expiration>2023-01-31 22:59:59</expiration>

in some body request expireDate is different so I changed test where I set the required time in the request and wait for the required time in the response

saw-jan · 2023-01-24T03:34:38Z

tests/acceptance/features/coreApiSharePublicLink3/allowGroupToCreatePublicLinks.feature

-      | expireDate | +3 days |
+      | expireDate | 2040-01-01T23:59:59+0100 |


Was this necessary?
Can we only assert the date (2040-01-01) but not the time in order to cope with the differences? That way we may use incremental days +3.

I did this for more transparency. If we use this aproach In the test, we can see what date format we use in the body of the request and what date format we get in the response. Unfortunately, we have a difference in this (I created a bug), and I have to postpone PR until it's clearer how it's supposed to work

we get a different date format in the response, so I:

created error Sharing to a group with an expiration date does not work #5442

check the date format (2040-01-01)

saw-jan

LGTM

SagarGi

lgtm 👍

sonarcloud · 2023-02-01T07:47:08Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Arthur has vacation

Author: Viktor Scharf <[email protected]> Date: Wed Feb 1 09:55:51 2023 +0100 create share with expirate date. refactoring code (#5424)

ScharfViktor force-pushed the shareResourceWithExpirateDate branch from 8ac521b to 71abe89 Compare January 20, 2023 11:28

ScharfViktor requested review from SagarGi, saw-jan and individual-it January 20, 2023 12:13

ScharfViktor force-pushed the shareResourceWithExpirateDate branch from 69ca246 to af30a39 Compare January 20, 2023 16:30

saw-jan reviewed Jan 23, 2023

View reviewed changes

tests/acceptance/features/apiSpacesShares/copySpaces.feature Outdated Show resolved Hide resolved

tests/acceptance/features/apiSpacesShares/copySpaces.feature Outdated Show resolved Hide resolved

saw-jan reviewed Jan 23, 2023

View reviewed changes

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved

saw-jan reviewed Jan 23, 2023

View reviewed changes

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved

individual-it previously requested changes Jan 23, 2023

View reviewed changes

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved

tests/acceptance/features/apiSpacesShares/shareSubItemOfSpace.feature Outdated Show resolved Hide resolved

ScharfViktor requested review from saw-jan and individual-it January 23, 2023 11:29

ScharfViktor changed the title ~~[test-only] ApiTest. creating a shared resource with an expiration date~~ [test-only][full-ci] ApiTest. creating a shared resource with an expiration date Jan 23, 2023

ScharfViktor force-pushed the shareResourceWithExpirateDate branch 4 times, most recently from e4c86f4 to 3b959b9 Compare January 23, 2023 21:49

saw-jan reviewed Jan 24, 2023

View reviewed changes

ScharfViktor mentioned this pull request Jan 24, 2023

Difference in expiration date format in the public link and share #5452

Open

ScharfViktor force-pushed the shareResourceWithExpirateDate branch 2 times, most recently from 71b2e3a to b6d5a4e Compare January 31, 2023 15:33

create share with expirate date. refactoring code

b6d5a4e

ScharfViktor added the Status:Needs-Review Needs review from a maintainer label Jan 31, 2023

saw-jan reviewed Feb 1, 2023

View reviewed changes

SagarGi reviewed Feb 1, 2023

View reviewed changes

saw-jan approved these changes Feb 1, 2023

View reviewed changes

ScharfViktor merged commit 486453b into master Feb 1, 2023

delete-merged-branch bot deleted the shareResourceWithExpirateDate branch February 1, 2023 08:55

ownclouders pushed a commit that referenced this pull request Feb 1, 2023

commit 486453b

543f1da

Author: Viktor Scharf <[email protected]> Date: Wed Feb 1 09:55:51 2023 +0100 create share with expirate date. refactoring code (#5424)

ScharfViktor mentioned this pull request Feb 8, 2023

ApiTest. new tests #5413

Closed

24 tasks

saw-jan pushed a commit that referenced this pull request Feb 28, 2023

create share with expirate date. refactoring code (#5424)

ae11fe0

saw-jan mentioned this pull request Feb 28, 2023

[tests-only][full-ci] Backport test PRs #5671

Merged

9 tasks

grgprarup pushed a commit that referenced this pull request Mar 2, 2023

create share with expirate date. refactoring code (#5424)

77f4068

grgprarup pushed a commit that referenced this pull request Mar 3, 2023

create share with expirate date. refactoring code (#5424)

c669648

phil-davis pushed a commit that referenced this pull request Mar 6, 2023

create share with expirate date. refactoring code (#5424)

338512b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test-only][full-ci] ApiTest. creating a shared resource with an expiration date #5424

[test-only][full-ci] ApiTest. creating a shared resource with an expiration date #5424

ScharfViktor commented Jan 18, 2023 •

edited

Loading

update-docs bot commented Jan 18, 2023

ownclouders commented Jan 18, 2023 •

edited

Loading

saw-jan left a comment

ScharfViktor commented Jan 23, 2023 •

edited

Loading

saw-jan Jan 24, 2023

ScharfViktor Jan 24, 2023

ScharfViktor Jan 31, 2023

saw-jan left a comment

SagarGi left a comment

sonarcloud bot commented Feb 1, 2023

		\| expireDate \| +3 days \|
		\| expireDate \| 2040-01-01T23:59:59+0100 \|

[test-only][full-ci] ApiTest. creating a shared resource with an expiration date #5424

[test-only][full-ci] ApiTest. creating a shared resource with an expiration date #5424

Conversation

ScharfViktor commented Jan 18, 2023 • edited Loading

update-docs bot commented Jan 18, 2023

ownclouders commented Jan 18, 2023 • edited Loading

saw-jan left a comment

Choose a reason for hiding this comment

ScharfViktor commented Jan 23, 2023 • edited Loading

saw-jan Jan 24, 2023

Choose a reason for hiding this comment

ScharfViktor Jan 24, 2023

Choose a reason for hiding this comment

ScharfViktor Jan 31, 2023

Choose a reason for hiding this comment

saw-jan left a comment

Choose a reason for hiding this comment

SagarGi left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Feb 1, 2023

ScharfViktor commented Jan 18, 2023 •

edited

Loading

ownclouders commented Jan 18, 2023 •

edited

Loading

ScharfViktor commented Jan 23, 2023 •

edited

Loading