Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Adds tests for checking href of the public link share #5401

Merged
merged 1 commit into from
Jan 16, 2023
Merged

[tests-only][full-ci] Adds tests for checking href of the public link share #5401

merged 1 commit into from
Jan 16, 2023

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jan 13, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT marked this pull request as ready for review January 13, 2023 10:57
@SwikritiT SwikritiT self-assigned this Jan 13, 2023
@SwikritiT SwikritiT changed the title [tests-only][full-ci] check href of public link [tests-only][full-ci] Adds tests for checking href of the public link share Jan 13, 2023
saw-jan
saw-jan reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwikritiT SwikritiT force-pushed the publiclink-propfind branch from 86d5f64 to 4e63ad9 Compare January 16, 2023 04:05
@SwikritiT SwikritiT force-pushed the publiclink-propfind branch from 4e63ad9 to 98ee2ec Compare January 16, 2023 06:03
@SwikritiT SwikritiT mentioned this pull request Jan 16, 2023
Merged
9 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

grgprarup
grgprarup approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SwikritiT SwikritiT merged commit 0d0f296 into stable-2.0 Jan 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the publiclink-propfind branch January 16, 2023 07:21
ownclouders pushed a commit that referenced this pull request Jan 16, 2023
@SwikritiT
commit 0d0f296
cf5382f 
Author: Swikriti Tripathi <[email protected]>
Date:   Mon Jan 16 13:06:51 2023 +0545

    Check herf of the public link file (#5401)
@SwikritiT SwikritiT mentioned this pull request Jan 16, 2023
Closed
ownclouders pushed a commit that referenced this pull request Jan 17, 2023
@SwikritiT
commit 0d0f296
4d9cdfa 
Author: Swikriti Tripathi <[email protected]>
Date:   Mon Jan 16 13:06:51 2023 +0545

    Check herf of the public link file (#5401)
ownclouders pushed a commit that referenced this pull request Jan 18, 2023
@SwikritiT
commit 0d0f296
d946378 
Author: Swikriti Tripathi <[email protected]>
Date:   Mon Jan 16 13:06:51 2023 +0545

    Check herf of the public link file (#5401)
ownclouders pushed a commit that referenced this pull request Jan 19, 2023
@SwikritiT
commit 0d0f296
c4a2bdb 
Author: Swikriti Tripathi <[email protected]>
Date:   Mon Jan 16 13:06:51 2023 +0545

    Check herf of the public link file (#5401)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@SagarGi SagarGi SagarGi approved these changes

@grgprarup grgprarup grgprarup approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@saw-jan saw-jan Awaiting requested review from saw-jan

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SwikritiT @grgprarup @SagarGi @saw-jan @ScharfViktor