Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add expiration to user and group shares #5389

Merged
merged 1 commit into from
Jan 12, 2023
Merged

add expiration to user and group shares #5389

merged 1 commit into from
Jan 12, 2023

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jan 12, 2023

Description

Added expiration to user and group shares.

How Has This Been Tested?

  • locally with a web browser

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Code changes

@C0rby C0rby requested review from aduffeck, butonic and fschade January 12, 2023 14:30
@C0rby C0rby self-assigned this Jan 12, 2023
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-3 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

micbar
micbar approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Replace of the cs3apis can be tackled later when their CI is back

@butonic butonic merged commit 958ba28 into master Jan 12, 2023
ownclouders pushed a commit that referenced this pull request Jan 12, 2023
commit 958ba28
79e29be 
Author: David Christofas <[email protected]>
Date:   Thu Jan 12 17:26:06 2023 +0100

    add expiration to user and group shares (#5389)
@butonic butonic mentioned this pull request Jan 12, 2023
Closed
@C0rby C0rby deleted the share-expiration branch January 13, 2023 11:06
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@butonic butonic butonic approved these changes

@aduffeck aduffeck Awaiting requested review from aduffeck

@fschade fschade Awaiting requested review from fschade

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@C0rby @ownclouders @butonic @micbar