Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve reva storage service descriptions #536

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Improve reva storage service descriptions #536

merged 1 commit into from
Sep 16, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Sep 9, 2020

The descriptions make it clearer that the services actually represent a
mount point in the combined storage. Each mount point can have a
different driver.

@PVince81 PVince81 requested a review from butonic September 9, 2020 10:35
@PVince81 PVince81 self-assigned this Sep 9, 2020
@phil-davis
Copy link
Contributor

Needs rebase.

runsh: Total unexpected passed scenarios throughout the test run:
apiShareManagement/acceptSharesToSharesFolder.feature:15 apiShareManagement/acceptSharesToSharesFolder.feature:22 apiShareManagement/acceptSharesToSharesFolder.feature:30 apiShareManagement/acceptSharesToSharesFolder.feature:52
make: *** [test-acceptance-api] Error 1

This branch does not seem to have the latest core commit id, and so does not run the new acceptSharesToSharesFolder feature.

@PVince81 PVince81 force-pushed the improve-reva-service-descriptions branch from 8bae044 to fd5899f Compare September 9, 2020 12:23
@PVince81
Copy link
Contributor Author

PVince81 commented Sep 9, 2020

rebased

@PVince81 PVince81 force-pushed the improve-reva-service-descriptions branch 2 times, most recently from a0fcad6 to 072e8ee Compare September 14, 2020 07:08
@PVince81
Copy link
Contributor Author

rebased

@PVince81 PVince81 force-pushed the improve-reva-service-descriptions branch from 072e8ee to 99dddaa Compare September 16, 2020 07:47
@PVince81
Copy link
Contributor Author

rebased again, hoping for green...

@phil-davis phil-davis force-pushed the improve-reva-service-descriptions branch from 99dddaa to 46d0926 Compare September 16, 2020 16:28
@phil-davis
Improve reva storage service descriptions
aa46f0a 
The descriptions make it clearer that the services actually represent a
mount point in the combined storage. Each mount point can have a
different driver.
@phil-davis phil-davis force-pushed the improve-reva-service-descriptions branch from 46d0926 to aa46f0a Compare September 16, 2020 16:29
@phil-davis phil-davis merged commit 7b8e9bc into master Sep 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the improve-reva-service-descriptions branch September 16, 2020 16:31
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

Assignees

@PVince81 PVince81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @phil-davis @butonic