Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make amount of group members in patch configurable. #5357

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Conversation

ainmosni
Copy link
Contributor

@ainmosni ainmosni commented Jan 9, 2023

This PR changes the following:

  • Create an API config section for API configurables.
  • Add a setting UserPatchLimit that controls how many users can be changed in a PATCH request.
  • Use this setting in the API to limit the amount of users that can be changed.

This PR changes the following:

* Create an API config section for API configurables.
* Add a setting `UserPatchLimit` that controls how many users can be changed in a PATCH request.
* Use this setting in the API to limit the amount of users that can be changed.
@update-docs
Copy link

update-docs bot commented Jan 9, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-2 failed. Further test are cancelled...

Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor naming suggestion. And could you maybe add a test case for this?

services/graph/pkg/config/config.go Outdated Show resolved Hide resolved
@rhafer rhafer changed the title Make amount of users in patch configurable. Make amount of group members in patch configurable. Jan 9, 2023
Also make test for old default match on the actual error message.
@ainmosni ainmosni force-pushed the ainmosni/issue/5262 branch from ef63ad5 to 6f55e32 Compare January 10, 2023 09:34
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rhafer rhafer merged commit 7034b3c into master Jan 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the ainmosni/issue/5262 branch January 10, 2023 10:45
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants