Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disassociate users from schools on school delete. #5343

Merged
merged 5 commits into from
Jan 6, 2023
Merged

Disassociate users from schools on school delete. #5343

merged 5 commits into from
Jan 6, 2023

Conversation

ainmosni
Copy link
Contributor

@ainmosni ainmosni commented Jan 5, 2023 •
edited
Loading

Description

This PR alters the DeleteEducationSchool to also disassociate the
users that were associated with the to-be-deleted school.

Related Issue

Motivation and Context

It solves that users still point to a non-existent school.

How Has This Been Tested?

  • test environment: I tested it with a local ldap, removing a school and checking if users were disassociated.
  • ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 5, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ainmosni ainmosni added the Status:Needs-Review Needs review from a maintainer label Jan 5, 2023
@ainmosni
Disassociate users from schools on school delete.
274da1b 
This PR alters the `DeleteEducationSchool` to also disassociate the
users that were associated with the to-be-deleted school.
@ainmosni
Add changelog.
163ca21
@ainmosni
Remove punctuation from changelog.
4f95693
@ainmosni
Remove redundant return statement.
542cb7b
@ainmosni
Skip when user not find.
098ba4a
@ainmosni ainmosni force-pushed the ainmosni/issue/5246 branch from a70f7e3 to 098ba4a Compare January 6, 2023 11:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

30.0% 30.0% Coverage
7.4% 7.4% Duplication

@butonic butonic dismissed rhafer’s stale review January 6, 2023 11:58

making ErrNotFound Public in #5353 fixed this

@butonic butonic merged commit f3924ca into master Jan 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the ainmosni/issue/5246 branch January 6, 2023 11:58
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer left review comments

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libregraph: DELETEing a school should delete all relations
3 participants
@ainmosni @rhafer @butonic