Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] ApiTest. checking the owner of the project space #5342

Closed
wants to merge 4 commits into from

Conversation

ScharfViktor
Copy link
Contributor

related #4419

@update-docs
Copy link

update-docs bot commented Jan 5, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade
Copy link
Contributor

fschade commented Jan 5, 2023

@ScharfViktor can we add this to the expected failures and merge it? I want to test it in #5341 which should make it pass.

@ScharfViktor ScharfViktor requested a review from fschade January 5, 2023 12:32
@ScharfViktor
Copy link
Contributor Author

@ScharfViktor can we add this to the expected failures and merge it? I want to test it in #5341 which should make it pass.

done

@ScharfViktor ScharfViktor requested a review from kobergj January 5, 2023 12:34
@ScharfViktor ScharfViktor requested a review from fschade January 5, 2023 13:58
@ScharfViktor ScharfViktor requested a review from fschade January 5, 2023 14:44
@fschade
Copy link
Contributor

fschade commented Jan 5, 2023

thanks, i cherry pick it in #5341 to see if it passes, give me one more ci run ;)
THX

@fschade
Copy link
Contributor

fschade commented Jan 5, 2023

@ScharfViktor i had a look, the space owner is still the spaceId (project space only).
I've change the owner in AsResourceInfo to the manager as a fallback, which is used in stat requests for example.

Therefor the test still fails (the graph drives endpoint still uses the spaceId as owner).
Let me know if this is ok for you :)

@butonic FYI

@ScharfViktor
Copy link
Contributor Author

Let me know if this is ok for you :)

For me it's okay because it doesn't break any business logic and everything still looks good on the UI

@ScharfViktor ScharfViktor deleted the checkProjectSpaceOwner branch April 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants