Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract rogue env vars #5164

Merged
merged 17 commits into from
Dec 13, 2022
Merged

Conversation

dragonchaser
Copy link
Contributor

@dragonchaser dragonchaser commented Nov 30, 2022

We have added a little tool that will extract global env vars, that are loaded
only through os.Getenv for documentation purposes

refs #4916

@update-docs
Copy link

update-docs bot commented Nov 30, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser force-pushed the extract-rogue-env-vars branch from 22d36cf to fc602cf Compare December 1, 2022 09:37
@kobergj kobergj force-pushed the extract-rogue-env-vars branch from ef6229f to cc48224 Compare December 8, 2022 08:23
@kobergj kobergj marked this pull request as ready for review December 8, 2022 08:25
@kobergj kobergj force-pushed the extract-rogue-env-vars branch from cc48224 to 2e2a717 Compare December 9, 2022 12:20
@mmattel
Copy link
Contributor

mmattel commented Dec 12, 2022

When running locally, regarding global_vars.yaml:

  • some entries are getting double present like MICRO_LOG_LEVEL (but not only)
    path: ocis-pkg/log/log.go:34
    path: ocis-pkg/log/log.go:30
  • strange env vars like (rawname):
    parts[0]
    registryAddressEnv
  • description text
    When adding a description text and re-running make docs-generate, there is no change in global_configvars.adoc

@kobergj kobergj force-pushed the extract-rogue-env-vars branch 3 times, most recently from ddee772 to a60d6a1 Compare December 13, 2022 11:04
dragonchaser and others added 14 commits December 13, 2022 12:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Co-authored-by: Martin <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
@mmattel mmattel force-pushed the extract-rogue-env-vars branch from a60d6a1 to 826a8b5 Compare December 13, 2022 11:18
@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiGraph-ocis failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mmattel mmattel merged commit 207efe3 into owncloud:master Dec 13, 2022
ownclouders pushed a commit that referenced this pull request Dec 13, 2022
Merge: 58f5c02 04d0e54
Author: Martin <[email protected]>
Date:   Tue Dec 13 14:12:40 2022 +0100

    Merge pull request #5164 from dragonchaser/extract-rogue-env-vars

    Extract rogue env vars
@micbar micbar mentioned this pull request May 3, 2023
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
86 tasks
@dragonchaser dragonchaser deleted the extract-rogue-env-vars branch February 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants