Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Add API tests for removing user from groups (graph API) #5104

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Nov 23, 2022

Description

Added API tests for removing user from groups

Added scenarios:

  1. Scenario: admin removes a user from a group
  2. Scenario: admin removes a user from a group with special characters
  3. Scenario: admin removes a user from a group having % and # in their names
  4. Scenario: admin removes a user from a group that has a forward-slash in the group name
  5. Scenario: admin tries to remove a user from a non-existing group
  6. Scenario: normal user tries to remove a user in their group

Related Issue

How Has This Been Tested?

  • test environment: local

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Nov 23, 2022
@saw-jan saw-jan mentioned this pull request Nov 23, 2022
22 tasks
@saw-jan saw-jan force-pushed the api-test/delete-user-group branch from 784d419 to afcee69 Compare November 24, 2022 03:56
@saw-jan saw-jan marked this pull request as ready for review November 24, 2022 04:10
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan requested a review from ScharfViktor November 24, 2022 11:28
@saw-jan saw-jan force-pushed the api-test/delete-user-group branch from afcee69 to 3c686cc Compare November 24, 2022 11:30
@saw-jan saw-jan force-pushed the api-test/delete-user-group branch from 3c686cc to 3d1f238 Compare November 25, 2022 06:29
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@saw-jan saw-jan force-pushed the api-test/delete-user-group branch from 3d1f238 to f6ae2cf Compare November 28, 2022 04:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScharfViktor ScharfViktor merged commit 1c246bb into master Nov 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the api-test/delete-user-group branch November 28, 2022 08:28
ownclouders pushed a commit that referenced this pull request Nov 28, 2022
Author: Sawjan Gurung <[email protected]>
Date:   Mon Nov 28 14:13:52 2022 +0545

    add graph api tests for removing user from group (#5104)

    extend tests

    refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants