Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Bump reva #5037

Merged
merged 3 commits into from
Nov 11, 2022
Merged

[full-ci] Bump reva #5037

merged 3 commits into from
Nov 11, 2022

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented Nov 11, 2022

Bump reva to bring in the the latest fixes.

Fixes #5025
Fixes #5027
Fixes #4506

@update-docs
Copy link

update-docs bot commented Nov 11, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Nov 11, 2022

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@micbar micbar changed the title Bump reva [full-ci] Bump reva Nov 11, 2022
@aduffeck aduffeck force-pushed the bump-reva branch 2 times, most recently from 08cb686 to b72977d Compare November 11, 2022 09:29
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butonic
Copy link
Member

butonic commented Nov 11, 2022

https://drone.owncloud.com/owncloud/ocis/16787/42/6

runsh: Total unexpected failed scenarios throughout the test run:
apiSpaces/changeSpaces.feature:222
apiSpaces/changeSpaces.feature:223
apiSpaces/changeSpaces.feature:224
apiSpaces/changeSpaces.feature:225

https://drone.owncloud.com/owncloud/ocis/16787/43/6

runsh: Total unexpected failed scenarios throughout the test run:
apiSpacesShares/shareOperations.feature:317
apiSpacesShares/shareOperations.feature:331
apiSpacesShares/shareOperations.feature:345

@kobergj might be related to cs3org/reva#3449?

@butonic
Copy link
Member

butonic commented Nov 11, 2022

  Scenario Outline: An admin user set an user personal space quota of via the Graph API                                                       # /drone/src/tests/acceptance/features/apiSpaces/changeSpaces.feature:215
    When user "Admin" changes the quota of the "Brian Murphy" space to "<quotaValue>"                                                         # SpacesContext::updateSpaceQuota()
    Then the HTTP status code should be "200"                                                                                                 # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    When user "Brian" uploads a file inside space "Brian Murphy" with content "file is more than 15 bytes" to "file.txt" using the WebDAV API # SpacesContext::theUserUploadsAFileToSpace()
    Then the HTTP status code should be <code>                                                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()

    Examples:
      | quotaValue | code                    |
      | 15         | "507"                   |
        Failed step: Then the HTTP status code should be "200"
        HTTP status code 404 is not the expected value 200
        Failed asserting that 404 matches expected '200'.
      | 10000      | between "201" and "204" |
        Failed step: Then the HTTP status code should be "200"
        HTTP status code 404 is not the expected value 200
        Failed asserting that 404 matches expected '200'.
      | 0          | between "201" and "204" |
        Failed step: Then the HTTP status code should be "200"
        HTTP status code 404 is not the expected value 200
        Failed asserting that 404 matches expected '200'.
      | -1         | between "201" and "204" |
        Failed step: Then the HTTP status code should be "200"
        HTTP status code 404 is not the expected value 200
        Failed asserting that 404 matches expected '200'.

should be fixed by cs3org/reva#3453, waiting for upstream merge

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic
Copy link
Member

butonic commented Nov 11, 2022

local api tests turning green: https://drone.owncloud.com/owncloud/ocis/16791
🤞

@micbar micbar merged commit 28e84d3 into owncloud:master Nov 11, 2022
ownclouders pushed a commit that referenced this pull request Nov 11, 2022
Merge: d74b879 a8848b2
Author: Michael Barz <[email protected]>
Date:   Fri Nov 11 15:58:26 2022 +0100

    Merge pull request #5037 from aduffeck/bump-reva

    [full-ci] Bump reva
@butonic butonic deleted the bump-reva branch November 11, 2022 15:18
@ScharfViktor
Copy link
Contributor

test https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/search.feature#L96 still failed and I could not find space by name localy

@ScharfViktor
Copy link
Contributor

re-tested #5027 and #5027 - work correct

ownclouders pushed a commit that referenced this pull request Nov 13, 2022
Merge: d74b879 a8848b2
Author: Michael Barz <[email protected]>
Date:   Fri Nov 11 15:58:26 2022 +0100

    Merge pull request #5037 from aduffeck/bump-reva

    [full-ci] Bump reva
ownclouders pushed a commit that referenced this pull request Nov 14, 2022
Merge: d74b879 a8848b2
Author: Michael Barz <[email protected]>
Date:   Fri Nov 11 15:58:26 2022 +0100

    Merge pull request #5037 from aduffeck/bump-reva

    [full-ci] Bump reva
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants