Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Added api test for sharing spaces to group #5023

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Nov 10, 2022

Description

Added API tests for sharing spaces with the group.
The sharing of space with a group is possible. But the backend and front end behave differently.
The backend allows the user to share space with the group but the front end does not allow a user to share space with a group.

Added scenarios:

  1. Scenario Outline: A user share a space to group with any role

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup mentioned this pull request Nov 10, 2022
22 tasks
@grgprarup grgprarup force-pushed the add-apitest-share-space-to-group branch 2 times, most recently from 2a877f8 to 70c7725 Compare November 14, 2022 06:07
@grgprarup grgprarup self-assigned this Nov 14, 2022
@grgprarup grgprarup force-pushed the add-apitest-share-space-to-group branch from 70c7725 to f7331f9 Compare November 16, 2022 09:02
@grgprarup grgprarup force-pushed the add-apitest-share-space-to-group branch from f7331f9 to abdd93b Compare December 12, 2022 09:56
@grgprarup grgprarup marked this pull request as ready for review December 12, 2022 10:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants