Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max AcquireLock Cycles and Bump Reva #4965

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Nov 3, 2022

Adds configuration option for max lock cycles and bumps reva

@@ -95,7 +95,8 @@ type OCISDriver struct {
// the general space alias, eg: `{{.SpaceType}}/{{.SpaceName | replace " " "-" | lower}}`
GeneralSpaceAliasTemplate string `yaml:"generalspacealias_template" env:"STORAGE_USERS_OCIS_GENERAL_SPACE_ALIAS_TEMPLATE" desc:"Template string to construct general space aliases."`
//ShareFolder defines the name of the folder jailing all shares
ShareFolder string `yaml:"share_folder" env:"STORAGE_USERS_OCIS_SHARE_FOLDER" desc:"Name of the folder jailing all shares."`
ShareFolder string `yaml:"share_folder" env:"STORAGE_USERS_OCIS_SHARE_FOLDER" desc:"Name of the folder jailing all shares."`
MaxAcquireLockCycles int `yaml:"max_acquire_lock_cycles" env:"STORAGE_USERS_OCIS_MAX_ACQUIRE_LOCK_CYCLES" desc:"When trying to lock files, ocis will try this amount of times to acquire the lock before failing. After each try it will wait for an increasing amount of time. Values of 0 or below will be ignored and the default value of 25 will be used"`
Copy link
Collaborator Author

@kobergj kobergj Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmattel following our discussion from #4958

This is the master version. Could you check my description?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kobergj kobergj merged commit 69c6013 into owncloud:master Nov 3, 2022
@kobergj kobergj deleted the MaxAcuireLockCycles branch November 3, 2022 14:11
ownclouders pushed a commit that referenced this pull request Nov 3, 2022
Merge: 92d3f77 27a1ab7
Author: kobergj <[email protected]>
Date:   Thu Nov 3 15:11:18 2022 +0100

    Merge pull request #4965 from kobergj/MaxAcuireLockCycles

    Max AcquireLock Cycles and Bump Reva
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants