-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ocis-reva to 0.13.0 #496
Conversation
@PVince81 this will need similar changes to expected-failures and tests like owncloud/ocis-reva#454 Do you want me to push that stuff? - Answer: I did it ;) |
Note: there are some core API test scenarios that started passing in https://cloud.drone.io/owncloud/ocis/1322/5/7
It seems that the OCIS user provisioning cannot cope with numeric-looking userid-username. So they tests have no hope to pass because they do not even get started. I raised https://github.com/owncloud/ocis-accounts/issues/97 to have a look at this. It does not block this PR. |
I more wonder why the tests passed before. Maybe a new restriction has been added in reva recently? |
The tests did not pass before, they failed in reva because of a real bug. I was expecting to see them start passing here. But they still fail here because they were failing for 2 reasons - the account provisioning problem and the reva bug. Now the reva bug is gone, but still the account provisioning problem is there. |
I grepped the code and I see there is a restriction in ocis-accounts: https://github.com/owncloud/ocis-accounts/blob/master/pkg/service/v0/accounts.go#L292 so this seems to be by design and we might need to permanently disable those tests as "expected behavior in OCIS". @butonic can you confirm ? |
yes, accounts MUST have a
|
That has:
It insists that a username/userid/email-address-first-part/whatever-you-call-it must start with an alpha or underscore. But that is just not true. For example a University I was enrolled at used the student number for usernames and email address - e.g. username "247843222" and email address "[email protected]" - that all works fine for cloud file sharing in oC10, cs3org/reva and owncloud/ocis-reva. So, IMO, we better make sure it works for |
hm, good point. I dug into the verification of unix usernames, because ultimately that username will appear as the username in an os that integrates with glauth to persist shares using acls. see https://unix.stackexchange.com/a/435120 and the systemd bug it caused: systemd/systemd#6237 |
No description provided.