Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Add TrashbinContext to local acceptance tests #495

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 26, 2020

Local API tests are getting:

https://cloud.drone.io/owncloud/ocis/1317/3/7

148 scenarios (143 passed, 5 undefined)
1118 steps (1092 passed, 21 undefined, 5 skipped)
3m58.15s (15.84Mb)

--- FeatureContext has missing steps. Define them with these snippets:

    /**
     * @Given as :arg1 file :arg2 should exist in the trashbin
     */
    public function asFileShouldExistInTheTrashbin($arg1, $arg2)
    {
        throw new PendingException();
    }
...

Trashbin tests were introduced in #489 but TrashbinContext was not added.

@phil-davis phil-davis self-assigned this Aug 26, 2020
@phil-davis
Copy link
Contributor Author

phil-davis commented Aug 26, 2020

Note: CI should fail when this happens - that needs looking into - issue owncloud/core#37853

@phil-davis
Copy link
Contributor Author

Local API acceptance tests are good: https://cloud.drone.io/owncloud/ocis/1318/3/7

148 scenarios (148 passed)
1118 steps (1118 passed)
3m38.76s (16.15Mb)
runsh: Total 148 scenarios (148 passed, 0 failed)
runsh: Exit code of main run: 0
runsh: There were no unexpected failures.
runsh: There were no unexpected success.

@individual-it individual-it merged commit 9601565 into master Aug 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the add-TrashbinContext branch August 27, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants