example config micro registry #4910
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| Type string `yaml:"type" env:"MICRO_REGISTRY"` | ||
| Addresses []string `yaml:"addresses" env:"MICRO_REGISTRY_ADDRESSES"` |
There was a problem hiding this comment.
Should't those envs start with OICS_ or APP_PROVIDER_ ?
There was a problem hiding this comment.
I just used the current ENV name for demo purposes. If we change it we need to check if we also need to keep backwards compatibility.
There was a problem hiding this comment.
Maybe to add new ones in parallel having the correct name as we "later" plan a deprication process anyways...?
There was a problem hiding this comment.
Actually in this case it might even need to stay MICRO_REGISTRY (haven't checked in detail) as go-micro itself make use of that variable.
There was a problem hiding this comment.
#3917 (Harmonize env variable naming for those which are not bound to a particular service)
@dragonchaser fyi
|
closing because I cannot work on this for the next months. |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: