-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] [full-ci] Cleanup spaces in all local API test suites #4456
Merged
phil-davis
merged 1 commit into
master
from
cleanup-spaces-in-all-local-API-test-suites
Aug 25, 2022
Merged
[tests-only] [full-ci] Cleanup spaces in all local API test suites #4456
phil-davis
merged 1 commit into
master
from
cleanup-spaces-in-all-local-API-test-suites
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
approved these changes
Aug 25, 2022
ScharfViktor
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strange, CI is failing, maybe you've to add OCS context too
┌─ @BeforeScenario # SpacesContext::setUpScenario()
│
╳ `OCSContext` context is not found in the suite environment. Have you registered it?
│
Scenario: send PUT requests to webDav endpoints as normal user with no password
e4d1a63
to
e57fa20
Compare
yes, the |
kiranparajuli589
approved these changes
Aug 25, 2022
e57fa20
to
eabb641
Compare
eabb641
to
4c58ce3
Compare
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Aug 25, 2022
ownclouders
pushed a commit
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is
AfterScenario
inSpacesContext
that callsdeleteAllProjectSpaces
anddeleteAllPersonalSpaces
to cleanup properly at the end of each scenario. See PR #4441 for the latest version of that code.But
SpacesContext
is not currently used in the other local API test suites. But those test suites do create users, and those users have a personal space. Those suites do not create project spaces - sodeleteAllProjectSpaces
will have nothing to do, that is OK. But it will be good fordeleteAllPersonalSpaces
to run in those test suites.This PR adds
SpacesContext
to those test suites. That will cause theAfterScenario
to be found and to be run.This is a follow-on related to issue #4390
How Has This Been Tested?
CI
Types of changes
Checklist: