Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename extensions to services (leftover occurences) #4407

Merged
merged 2 commits into from
Aug 18, 2022
Merged

rename extensions to services (leftover occurences) #4407

merged 2 commits into from
Aug 18, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Aug 17, 2022 •
edited
Loading

Description

renames all leftover occurences of "extension" to "service"

Related Issue

Motivation and Context

consequent naming

How Has This Been Tested?

  • run cli locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 17, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Aug 17, 2022 •
edited
Loading

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@wkloucek wkloucek requested review from dragonchaser, butonic and kobergj and removed request for lookacat and kulmann August 18, 2022 08:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
45.9% 45.9% Duplication

@wkloucek wkloucek merged commit 46706ff into owncloud:master Aug 18, 2022
@wkloucek wkloucek deleted the rename-extensions-to-services-reloaded branch August 18, 2022 12:03
ownclouders pushed a commit that referenced this pull request Aug 18, 2022
@wkloucek
commit 46706ff
f01f04a 
Merge: 034c57a 60689c9
Author: Willy Kloucek <[email protected]>
Date:   Thu Aug 18 14:03:20 2022 +0200

    Merge pull request #4407 from wkloucek/rename-extensions-to-services-reloaded

    rename extensions to services (leftover occurences)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @ownclouders @kobergj