restructure storage-users upload command

[wkloucek]

Description

moves the "uploads" command of the storage-users service into a subsection "maintenance", rewords the descriptions and renames the ocis storage-users uploads purge command into clean (breaking change).

Before:

$ ocis storage-users help   
NAME:
   ocis storage-users - storage-users extension commands

USAGE:
   ocis storage-users [global options] command [command options] [arguments...]

COMMANDS:
   uploads  manage uploads
   help, h  Shows a list of commands or help for one command
   info:
     health   check health status
     version  print the version of this binary and the running extension instances
   server:
     server  start storage-users extension without runtime (unsupervised mode)

GLOBAL OPTIONS:
   --help, -h  show help (default: false)

After:

ocis storage-users        
NAME:
   ocis storage-users - storage-users extension commands

USAGE:
   ocis storage-users command [command options] [arguments...]

COMMANDS:
   help, h  Shows a list of commands or help for one command
   info:
     health   check health status
     version  print the version of this binary and the running extension instances
   maintenance:
     uploads  manage unfinished uploads
   server:
     server  start storage-users extension without runtime (unsupervised mode)

OPTIONS:
   --help, -h  show help (default: false)

Before:

ocis storage-users uploads
NAME:
   ocis storage-users uploads - manage uploads

USAGE:
   ocis storage-users uploads command [command options] [arguments...]

COMMANDS:
   help, h  Shows a list of commands or help for one command
   services:
     list   Print a list of all incomplete uploads
     purge  Let storage-users extension clean up leftovers from expired downloads

OPTIONS:
   --help, -h  show help (default: false)

After:

ocis storage-users uploads
NAME:
   ocis storage-users uploads - manage unfinished uploads

USAGE:
   ocis storage-users uploads command [command options] [arguments...]

COMMANDS:
   list     Print a list of all incomplete uploads
   clean    Clean up leftovers from expired uploads
   help, h  Shows a list of commands or help for one command

OPTIONS:
   --help, -h  show help (default: false)

Related Issue

Motivation and Context

have a category for a better overview

How Has This Been Tested?

• print the help locally

Screenshots (if appropriate):

see description for output

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[mmattel]

The full help text shows:

   maintenance:
     uploads  manage uploads

When reading this, I interpret that I can manage uploads in general but only if you go deeper you see that it is to fix upload issues. Maybe to write: uploads manage expired or aborted uploads ?

[wkloucek]

The full help text shows:

   maintenance:
     uploads  manage uploads

When reading this, I interpret that I can manage uploads in general but only if you go deeper you see that it is to fix upload issues. Maybe to write: uploads manage expired or aborted uploads ?

we decided to use the texts from 7d76650

[mmattel]

I was not able to check this but want to highlight a possible thing to be fixed too:

From the old outputs:

$ ocis storage-users uploads list
Incomplete uploads:
 - 455bd640-cd08-46e8-a5a0-9304908bd40a (file_example_PPT_1MB.ppt, Size: 1028608, Expires: 2022-08-17T12:35:34+02:00)

$ ocis storage-users uploads clear
Purging 455bd640-cd08-46e8-a5a0-9304908bd40a (Filename: file_example_PPT_1MB.ppt, Size: 1028608, Expires: 2022-08-17T12:35:34+02:00)

Should'nt this be:
Incomplete uploads --> Unfinished uploads and
Purging --> Clearing ?

Note that Unfinished uploads has a new line starting with the list of items while Clearing does not and no list item (dash) at the beginning but imho should have...

It should look like:

$ ocis storage-users uploads list
Unfinished uploads:
 - 455bd640-cd08-46e8-a5a0-9304908bd40a (file_example_PPT_1MB.ppt, Size: 1028608, Expires: 2022-08-17T12:35:34+02:00)

$ ocis storage-users uploads clear
Clearing
- 455bd640-cd08-46e8-a5a0-9304908bd40a (Filename: file_example_PPT_1MB.ppt, Size: 1028608, Expires: 2022-08-17T12:35:34+02:00)

[wkloucek]

Now it is:

ocis storage-users uploads     
NAME:
   ocis storage-users uploads - manage unfinished uploads

USAGE:
   ocis storage-users uploads command [command options] [arguments...]

COMMANDS:
   list     Print a list of all incomplete uploads
   clean    Clean up leftovers from expired uploads
   help, h  Shows a list of commands or help for one command

OPTIONS:
   --help, -h  show help (default: false)
   ocis storage-users uploads     
NAME:
   ocis storage-users uploads - manage unfinished uploads

USAGE:
   ocis storage-users uploads command [command options] [arguments...]

COMMANDS:
   list     Print a list of all incomplete uploads
   clean    Clean up leftovers from expired uploads
   help, h  Shows a list of commands or help for one command

OPTIONS:
   --help, -h  show help (default: false)

ocis storage-users uploads list        
Incomplete uploads:
 - add982e4-6d6d-4d31-8f48-84cda9bdcc4b (file_example_ODP_1MB.otp, Size: 932601, Expires: 2022-08-18T05:27:41+02:00)

ocis storage-users uploads clean
Cleaned uploads:
 - add982e4-6d6d-4d31-8f48-84cda9bdcc4b (file_example_ODP_1MB.otp, Size: 932601, Expires: 2022-08-18T05:27:41+02:00)

[ownclouders]

💥 Acceptance test Core-API-Tests-ocis-storage-6 failed. Further test are cancelled...

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
44.4% Duplication