Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] zip before cache and unzip on restore #4397

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[ci] zip before cache and unzip on restore #4397

merged 1 commit into from
Aug 18, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Aug 16, 2022 •
edited
Loading

Description

  • Zip the web, yarn files to be cached.
  • Unzip the cache on restore

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 force-pushed the zip-resource-to-cache branch 2 times, most recently from 070b7cd to 9f0fbd8 Compare August 16, 2022 07:20
@ownclouders
Copy link
Contributor

ownclouders commented Aug 16, 2022 •
edited
Loading

💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled...

@kiranparajuli589 kiranparajuli589 force-pushed the zip-resource-to-cache branch 27 times, most recently from 188cc99 to 04f1365 Compare August 17, 2022 08:46
@kiranparajuli589 kiranparajuli589 force-pushed the zip-resource-to-cache branch 2 times, most recently from 80ca4e5 to 0050c3c Compare August 18, 2022 04:17
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review August 18, 2022 04:21
@kiranparajuli589 kiranparajuli589 self-assigned this Aug 18, 2022
@kiranparajuli589
Zip before cache
c430c18 
Signed-off-by: Kiran Parajuli <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@owncloud owncloud deleted a comment from update-docs bot Aug 18, 2022
phil-davis
phil-davis approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grgprarup
grgprarup reviewed Aug 18, 2022
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis phil-davis merged commit 04a4933 into master Aug 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the zip-resource-to-cache branch August 18, 2022 05:59
ownclouders pushed a commit that referenced this pull request Aug 18, 2022
@phil-davis
commit 04a4933
ef8bcd8 
Merge: 152ce60 c430c18
Author: Phil Davis <[email protected]>
Date:   Thu Aug 18 11:44:12 2022 +0545

    Merge pull request #4397 from owncloud/zip-resource-to-cache

    [ci] zip before cache and unzip on restore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup left review comments

@phil-davis phil-davis phil-davis approved these changes

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

@sushmita56 sushmita56 Awaiting requested review from sushmita56

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiranparajuli589 @ownclouders @phil-davis @grgprarup