Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Autocreate IDP private key also if file exists but is empty #4394

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Bugfix: Autocreate IDP private key also if file exists but is empty #4394

merged 1 commit into from
Aug 15, 2022

Conversation

wkloucek
Copy link
Contributor

Description

Bugfix: Autocreate IDP private key also if file exists but is empty

We've fixed the behavior for the IDP private key generation so that
a private key is also generated when the file already exists but is empty.

Related Issue

  • Boostrap issues on continously deployed oCIS demo instances

Motivation and Context

Somehow the IDP`s private-key.pem ends up as empty file after initalization. Therefore oCIS is stuck in a reboot loop sometimes.
If the private-key.pem is empty we can safely just overwrite it to prevent the reboot loop.

How Has This Been Tested?

  • rm private-key.pem from the IDP data directory and create a empty file instead. oCIS from master does not start. oCIS from this PR will start just fine.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 15, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested review from C0rby and kobergj August 15, 2022 09:16
@wkloucek wkloucek merged commit d6f03d1 into owncloud:master Aug 15, 2022
@wkloucek wkloucek deleted the idp-init-empty-file branch August 15, 2022 10:49
ownclouders pushed a commit that referenced this pull request Aug 15, 2022
Merge: 24edee9 19e3169
Author: Willy Kloucek <[email protected]>
Date:   Mon Aug 15 12:49:49 2022 +0200

    Merge pull request #4394 from wkloucek/idp-init-empty-file

    Bugfix: Autocreate IDP private key also if file exists but is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants