Fix handling of invalid LDAP users and groups #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When expanding members of an LDAP group we did two group lookup per Group. This can be avoided by expanding the members right from the Group entry of the first query. This also add some more unit test coverage, especially to the expand/select group member test cases.
|
Kudos, SonarCloud Quality Gate passed! |
micbar
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We fixed an issue where ocis would exit with a panic when LDAP users or groups where missing required attributes (e.g. the id)
User and Groups missing any of the required attributes are now ignored.
Related Issue
Types of changes
Checklist: