Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]added test scenarios for copy folder request #4313

Merged
merged 1 commit into from
Aug 8, 2022
Merged

[tests-only][full-ci]added test scenarios for copy folder request #4313

merged 1 commit into from
Aug 8, 2022

Conversation

sushmita56
Copy link
Contributor

Description

This PR adds COPY request implementation for copying folders between different spaces (Personal, Shares Jail, Project)

Related Issue

#4087

@sushmita56 sushmita56 self-assigned this Aug 3, 2022
@sushmita56 sushmita56 force-pushed the addSpacesTestForFolderCopyOperation branch 2 times, most recently from 88bd610 to a082d50 Compare August 4, 2022 04:18
@sushmita56 sushmita56 marked this pull request as ready for review August 4, 2022 04:48
@grgprarup
Copy link
Contributor

@sushmita56 There are many scenarios with similar scenarios descriptions and steps. IMHO that can be merged.

@sushmita56 sushmita56 force-pushed the addSpacesTestForFolderCopyOperation branch from 1209a70 to b51d623 Compare August 4, 2022 11:35
grgprarup
grgprarup reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if CI is happy.

@sushmita56 sushmita56 requested a review from SagarGi August 5, 2022 04:25
kiranparajuli589
kiranparajuli589 reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sushmita56 sushmita56 force-pushed the addSpacesTestForFolderCopyOperation branch from 9da23ab to 13a5638 Compare August 5, 2022 05:49
SagarGi
SagarGi reviewed Aug 5, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 let CI be green

SwikritiT
SwikritiT reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the above little comment rest LGTM

@sushmita56 sushmita56 force-pushed the addSpacesTestForFolderCopyOperation branch from 13a5638 to e6da058 Compare August 5, 2022 06:41
@sushmita56 sushmita56 requested a review from SwikritiT August 5, 2022 06:41
@sushmita56 sushmita56 force-pushed the addSpacesTestForFolderCopyOperation branch from e6da058 to 136f124 Compare August 5, 2022 06:42
SwikritiT
SwikritiT reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushmita56 sushmita56 force-pushed the addSpacesTestForFolderCopyOperation branch from 136f124 to 93f9db7 Compare August 8, 2022 04:21
@sushmita56
added test for copy folder operation
6064220 
modified steps of scenarios related to shares jail space

updated expected to failure by shares jail

addressed review

removed shares jail expected to failure
@sushmita56 sushmita56 force-pushed the addSpacesTestForFolderCopyOperation branch from 93f9db7 to 6064220 Compare August 8, 2022 10:52
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sushmita56 sushmita56 merged commit ea75391 into master Aug 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the addSpacesTestForFolderCopyOperation branch August 8, 2022 11:35
ownclouders pushed a commit that referenced this pull request Aug 8, 2022
@sushmita56
commit ea75391
c0a26f7 
Merge: 67bf4d3 6064220
Author: Sushmita Poudel <[email protected]>
Date:   Mon Aug 8 17:20:11 2022 +0545

    Merge pull request #4313 from owncloud/addSpacesTestForFolderCopyOperation

    [tests-only][full-ci]added test scenarios for copy folder request
@SagarGi SagarGi mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@grgprarup grgprarup grgprarup left review comments

@individual-it individual-it individual-it approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@sushmita56 sushmita56

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sushmita56 @grgprarup @individual-it @kiranparajuli589 @SwikritiT @SagarGi