Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce insecure flag for smtp email notifications #4279

Merged
merged 3 commits into from
Jul 26, 2022
Merged

introduce insecure flag for smtp email notifications #4279

merged 3 commits into from
Jul 26, 2022

Conversation

wkloucek
Copy link
Contributor

Description

We've introduced the NOTIFICATIONS_SMTP_INSECURE configuration option,
that let's you skip certificate verification for smtp email servers.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • with the Traefik deployment example

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

kobergj
kobergj requested changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Just some nitpicking as always...

@wkloucek wkloucek requested a review from kobergj July 25, 2022 14:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit ed49e17 into owncloud:master Jul 26, 2022
@wkloucek wkloucek deleted the mail-insecure branch July 26, 2022 05:18
ownclouders pushed a commit that referenced this pull request Jul 26, 2022
@wkloucek
commit ed49e17
0fb7a99 
Merge: 771d6d6 7365d6c
Author: Willy Kloucek <[email protected]>
Date:   Tue Jul 26 07:18:18 2022 +0200

    Merge pull request #4279 from wkloucek/mail-insecure

    introduce insecure flag for smtp email notifications
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@butonic butonic Awaiting requested review from butonic

@micbar micbar Awaiting requested review from micbar

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @kobergj