Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Add search unit test to ci #4259

Merged
merged 2 commits into from
Jul 22, 2022
Merged

[tests-only] Add search unit test to ci #4259

merged 2 commits into from
Jul 22, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jul 22, 2022

Signed-off-by: jkoberg [email protected]

Description

Search unit test where not running in ci. Now they do

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kobergj
add Makefile
e6ef03f 
Signed-off-by: jkoberg <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

wkloucek
wkloucek approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing them back!

phil-davis
phil-davis approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://drone.owncloud.com/owncloud/ocis/13755/24/5
tests ran - good

@phil-davis phil-davis merged commit 5db4b3a into owncloud:master Jul 22, 2022
ownclouders pushed a commit that referenced this pull request Jul 22, 2022
@phil-davis
commit 5db4b3a
ddfc555 
Merge: 1c98198 e6ef03f
Author: Phil Davis <[email protected]>
Date:   Fri Jul 22 15:47:44 2022 +0545

    Merge pull request #4259 from kobergj/AddSearchUnittestsToCI

    [tests-only] Add search unit test to ci
@kobergj kobergj deleted the AddSearchUnittestsToCI branch July 22, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@wkloucek wkloucek wkloucek approved these changes

@micbar micbar Awaiting requested review from micbar

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobergj @phil-davis @wkloucek