Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow providing list of services not to start #4254

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Allow providing list of services not to start #4254

merged 3 commits into from
Jul 21, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jul 21, 2022

Signed-off-by: jkoberg [email protected]

Description

Allow providing list of services NOT to start

Until now if one wanted to use a custom version of a service, one
needed to provide OCIS_RUN_SERVICES which is a list of all services to start.
Now one can provide OCIS_EXCLUDE_RUN_SERVICES which is a list of only services not to start

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kobergj kobergj changed the title allow providing list of services not to start Allow providing list of services not to start Jul 21, 2022
@kobergj kobergj force-pushed the AddConfigOptionToExcludeServices branch from c9eb671 to baaa0ee Compare July 21, 2022 13:50
@kobergj kobergj force-pushed the AddConfigOptionToExcludeServices branch from baaa0ee to 4b8d1ac Compare July 21, 2022 13:51
dragonchaser
dragonchaser suggested changes Jul 21, 2022
View reviewed changes
ocis/pkg/runtime/service/service.go Outdated Show resolved Hide resolved
mmattel
mmattel approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the description pov. Will update the docs when merged.

@ownclouders
Copy link
Contributor

ownclouders commented Jul 21, 2022 •
edited
Loading

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

@kobergj
make runset a map
f64ea7d 
Signed-off-by: jkoberg <[email protected]>
dragonchaser
dragonchaser approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mmattel mmattel merged commit 90c06eb into owncloud:master Jul 21, 2022
ownclouders pushed a commit that referenced this pull request Jul 21, 2022
@mmattel
commit 90c06eb
156f56c 
Merge: 0f3d6d5 f64ea7d
Author: Martin <[email protected]>
Date:   Thu Jul 21 17:33:15 2022 +0200

    Merge pull request #4254 from kobergj/AddConfigOptionToExcludeServices
@kobergj kobergj deleted the AddConfigOptionToExcludeServices branch July 22, 2022 07:16
@mmattel mmattel mentioned this pull request Jul 22, 2022
Closed
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis left review comments

@mmattel mmattel mmattel approved these changes

@dragonchaser dragonchaser dragonchaser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kobergj @ownclouders @dragonchaser @phil-davis @mmattel