Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Bump web to v5.7.0-rc.3 #4140

Merged
merged 6 commits into from
Jul 8, 2022
Merged

[full-ci] Bump web to v5.7.0-rc.3 #4140

merged 6 commits into from
Jul 8, 2022

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Jul 8, 2022

Bump web to v5.7.0-rc.3

@kulmann kulmann requested a review from pascalwengerter as a code owner July 8, 2022 07:07
@kulmann kulmann changed the title Bump web to v5.7.0-rc.3 [full-ci] Bump web to v5.7.0-rc.3 Jul 8, 2022
@kulmann kulmann force-pushed the update-web-5.7.0-rc.3 branch from 5db5e0d to e13d4f8 Compare July 8, 2022 07:07
@kulmann kulmann requested a review from micbar July 8, 2022 07:07
@kulmann kulmann self-assigned this Jul 8, 2022
@kulmann
Switch default value for resharing in capabilities to true
15b0f64 
oC Web v5.0.7-rc.3 supports resharing, so we can flip the default value
of the capability from false to true.
@kulmann kulmann requested a review from lookacat as a code owner July 8, 2022 15:36
@kulmann
Copy link
Contributor Author

kulmann commented Jul 8, 2022

Figured out everything except two unexpected failures so far:
https://drone.owncloud.com/owncloud/ocis/13267/66/12

webUISharingPublicManagement/shareByPublicLink.feature:89 and webUISharingPublicManagement/publicLinkIndicator.feature:110 failed reliably in all CI runs. Didn't find a reason, yet.

@kulmann
Copy link
Contributor Author

kulmann commented Jul 8, 2022

Figured out everything except two unexpected failures so far: https://drone.owncloud.com/owncloud/ocis/13267/66/12

webUISharingPublicManagement/shareByPublicLink.feature:89 and webUISharingPublicManagement/publicLinkIndicator.feature:110 failed reliably in all CI runs. Didn't find a reason, yet.

Think I found it. We introduced a hacky option for the config.json to align notification messages top-center instead of the default bottom-right location, so that CI doesn't need to be adjusted in that regard. Aligned with the drone config.json of the web repo now, see 999def4

@kulmann
Copy link
Contributor Author

kulmann commented Jul 8, 2022

@pascalwengerter @fschade when this PR gets merged we can remove "FRONTEND_ENABLE_RESHARING": "true" in web's drone and dev-setup config for the next ocis commit id bump. Could you take care of that please? :-)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 981c448 into master Jul 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-web-5.7.0-rc.3 branch July 8, 2022 17:15
ownclouders pushed a commit that referenced this pull request Jul 8, 2022
@kulmann
commit 981c448
8e29218 
Author: Benedikt Kulmann <[email protected]>
Date:   Fri Jul 8 19:15:34 2022 +0200

    [full-ci] Bump web to v5.7.0-rc.3 (#4140)

    * Bump web to v5.7.0-rc.4

    * Switch default value for resharing in capabilities to true

    * Fix access token usage in settings ui
@micbar micbar mentioned this pull request Jul 19, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@micbar micbar Awaiting requested review from micbar

@wkloucek wkloucek Awaiting requested review from wkloucek

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @phil-davis