Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Added test scenarios for copy Request #4126

Merged
merged 3 commits into from
Jul 21, 2022
Merged

[tests-only][full-ci]Added test scenarios for copy Request #4126

merged 3 commits into from
Jul 21, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jul 7, 2022 •
edited
Loading

Description

This PR adds COPY request implementation for copying files between different spaces (Personal, Shares Jail, Project)

Related Issue

#4087

@update-docs
Copy link

update-docs bot commented Jul 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@SagarGi SagarGi self-assigned this Jul 7, 2022
@SagarGi SagarGi added the QA:team label Jul 7, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Jul 7, 2022 •
edited
Loading

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch 5 times, most recently from 491d10d to 7164b1a Compare July 11, 2022 07:18
@SagarGi SagarGi mentioned this pull request Jul 11, 2022
Closed
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch 4 times, most recently from ac25e58 to 5d0efab Compare July 11, 2022 11:17
@SagarGi SagarGi marked this pull request as ready for review July 11, 2022 11:26
@SagarGi SagarGi requested a review from individual-it July 11, 2022 11:26
kiranparajuli589
kiranparajuli589 reviewed Jul 12, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, some optimizations:

tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpaces/copySpaces.feature Show resolved Hide resolved
tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch from 5d0efab to dbd95f0 Compare July 12, 2022 10:23
@SagarGi SagarGi requested a review from kiranparajuli589 July 12, 2022 10:24
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch from dbd95f0 to cee8107 Compare July 12, 2022 10:25
@SagarGi SagarGi mentioned this pull request Jul 12, 2022
Merged
@SagarGi SagarGi requested a review from saw-jan July 14, 2022 03:39
kiranparajuli589
kiranparajuli589 reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm 👍

tests/acceptance/features/apiSpaces/copySpaces.feature Show resolved Hide resolved
@phil-davis phil-davis self-requested a review July 14, 2022 06:50
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch from a668f09 to 6d24e0f Compare July 15, 2022 04:03
@SagarGi SagarGi changed the title Added test scenarios for copy Request [tests-only][full-ci]Added test scenarios for copy Request Jul 15, 2022
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch from 6d24e0f to e7056b8 Compare July 15, 2022 04:43
@SagarGi SagarGi requested a review from kiranparajuli589 July 15, 2022 04:43
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch from e7056b8 to c344ad9 Compare July 18, 2022 07:28
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch from c344ad9 to bc7f18f Compare July 19, 2022 09:55
@SagarGi SagarGi requested a review from SwikritiT July 19, 2022 10:01
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch 2 times, most recently from 67af1eb to 0221068 Compare July 20, 2022 03:56
@SagarGi SagarGi force-pushed the addSpacesTestForCOPYReq branch from 0221068 to f29b7c1 Compare July 20, 2022 06:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ScharfViktor
ScharfViktor approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared all scenarios with my table. That's right. cool, thank you.

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Jul 20, 2022 •
edited
Loading

CI is green https://drone.owncloud.com/owncloud/ocis/13644
Why is CI pending in github?

@individual-it
Copy link
Member

somehow drone did not communicate back to github, I've set the status manually to success

@individual-it individual-it merged commit 176dd32 into master Jul 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the addSpacesTestForCOPYReq branch July 21, 2022 02:34
ownclouders pushed a commit that referenced this pull request Jul 21, 2022
@individual-it
commit 176dd32
ce71fc6 
Merge: b698aa6 f29b7c1
Author: Artur Neumann <[email protected]>
Date:   Thu Jul 21 08:19:49 2022 +0545

    Merge pull request #4126 from owncloud/addSpacesTestForCOPYReq

    [tests-only][full-ci]Added test scenarios for copy Request
@SwikritiT SwikritiT mentioned this pull request Aug 26, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@saw-jan saw-jan Awaiting requested review from saw-jan

@phil-davis phil-davis Awaiting requested review from phil-davis

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SagarGi @ownclouders @ScharfViktor @individual-it @phil-davis @kiranparajuli589 @SwikritiT @saw-jan