Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Do not run full-ci on tagging #4112

Merged
merged 1 commit into from
Jul 19, 2022
Merged

[full-ci] [tests-only] Do not run full-ci on tagging #4112

merged 1 commit into from
Jul 19, 2022
+17 −25

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jul 6, 2022 •
edited
Loading

Description

The release process is

  1. create a branch
  2. bump version & prepare changelog
  3. commit version bump
  4. Create a pull request from release branch against master with full-ci
  5. Tag
  6. merge the PR

Since we are already running full ci in step 4, it should not be necessary to run it fully in step 5.
This PR makes necessary changes so that we don't run full ci in tagging as well.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this Jul 6, 2022
@SwikritiT SwikritiT force-pushed the donot-run-full-ci-on-tag branch from 7425f9e to cd18217 Compare July 7, 2022 04:24
@SwikritiT SwikritiT force-pushed the donot-run-full-ci-on-tag branch 3 times, most recently from edd3622 to d72f858 Compare July 15, 2022 04:52
@SwikritiT SwikritiT force-pushed the donot-run-full-ci-on-tag branch from d72f858 to 623a8e3 Compare July 18, 2022 06:31
@SwikritiT SwikritiT marked this pull request as ready for review July 18, 2022 06:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it
Copy link
Member

LGTM @micbar are you happy to merge this?

phil-davis
phil-davis reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @micbar please approve and merge if you are happy to have this for the current release process.

@micbar micbar merged commit 8af6fcf into master Jul 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the donot-run-full-ci-on-tag branch July 19, 2022 09:26
ownclouders pushed a commit that referenced this pull request Jul 19, 2022
@micbar
commit 8af6fcf
8ac36b2 
Merge: a7832ea 623a8e3
Author: Michael Barz <[email protected]>
Date:   Tue Jul 19 11:26:44 2022 +0200

    Merge pull request #4112 from owncloud/donot-run-full-ci-on-tag

    [full-ci] [tests-only] Do not run full-ci on tagging
@SwikritiT SwikritiT mentioned this pull request Jul 20, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis left review comments

@micbar micbar micbar approved these changes

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@wkloucek wkloucek Awaiting requested review from wkloucek

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run full-ci not on tagging but on tip the branch and then tag without CI
4 participants
@SwikritiT @individual-it @phil-davis @micbar