Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add drives output & user filter #4072

Merged
merged 5 commits into from
Aug 1, 2022
Merged

Add drives output & user filter #4072

merged 5 commits into from
Aug 1, 2022

Conversation

dragonchaser
Copy link
Contributor

No description provided.

@update-docs
Copy link

update-docs bot commented Jun 30, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Jun 30, 2022 •
edited
Loading

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch 2 times, most recently from 03b68ff to 0e12e0d Compare July 1, 2022 14:33
@butonic butonic force-pushed the fix-user-drives-endpoint branch from 0e12e0d to 4348d9d Compare July 14, 2022 12:50
@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch from 32a3108 to 434b8bf Compare July 18, 2022 06:48
@butonic butonic mentioned this pull request Jul 18, 2022
Merged
@dragonchaser dragonchaser changed the title add drives output Add drives output & user filter Jul 18, 2022
@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch from 44ba7af to d9a4b11 Compare July 19, 2022 07:21
@dragonchaser dragonchaser marked this pull request as ready for review July 19, 2022 09:57
@dragonchaser dragonchaser marked this pull request as draft July 19, 2022 14:20
@dragonchaser
Copy link
Contributor Author

Reverted back to draft, there is a bug, only admins can list drives atm. Needs more logic in reva.

@dragonchaser dragonchaser marked this pull request as ready for review July 27, 2022 11:18
@dragonchaser dragonchaser requested a review from micbar July 27, 2022 11:18
@dragonchaser
Copy link
Contributor Author

dragonchaser commented Jul 27, 2022 •
edited
Loading

Needs cs3org/reva#3096 in reva release before merging.

@dragonchaser dragonchaser mentioned this pull request Jul 27, 2022
Merged
@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch 2 times, most recently from fd83931 to 52f4300 Compare July 28, 2022 11:26
@phil-davis
Copy link
Contributor

phil-davis commented Jul 29, 2022 •
edited
Loading

https://drone.owncloud.com/owncloud/ocis/13901/42/8

runsh: Total unexpected failed scenarios throughout the test run:
apiSpaces/restoreSpaces.feature:63
apiSpaces/restoreSpaces.feature:64

Maybe this is a flaky thing, unrelated to this PR? I raised PR #4298 to tidy up the error checks in that code. But the error itself is not expected.

I restarted CI.

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/13913/42/8

The same scenarios failed again:

runsh: Total unexpected failed scenarios throughout the test run:
apiSpaces/restoreSpaces.feature:63
apiSpaces/restoreSpaces.feature:64

It seems that either there is a regression (code to be fixed), or a change in behavior (tests to be adjusted)

@dragonchaser
Copy link
Contributor Author

@phil-davis seems to be a bug in the code we introduced to reva: cs3org/reva#3109

@dragonchaser dragonchaser marked this pull request as draft July 29, 2022 12:11
@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch from 2771463 to 9180639 Compare July 29, 2022 12:36
@dragonchaser dragonchaser marked this pull request as ready for review July 29, 2022 12:36
@dragonchaser
add drives output
1e21e23 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
incorporate requested changes
a030459 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
add changelog
7d84496 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser
use reva/v2@edge
3da88ef 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch from 9180639 to 3da88ef Compare July 29, 2022 12:39
@dragonchaser dragonchaser marked this pull request as draft July 29, 2022 13:44
@dragonchaser
Copy link
Contributor Author

will be superseded by #4244 , delete as soon as it is merged!

@dragonchaser dragonchaser marked this pull request as ready for review August 1, 2022 08:13
@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch 2 times, most recently from 37f01f5 to f044831 Compare August 1, 2022 08:36
micbar
micbar approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch from f044831 to 6146f45 Compare August 1, 2022 08:55
@dragonchaser
add expected failures
3212348 
Signed-off-by: Christian Richter <[email protected]>
@dragonchaser dragonchaser force-pushed the fix-user-drives-endpoint branch from 6146f45 to 3212348 Compare August 1, 2022 09:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dragonchaser dragonchaser merged commit c94960c into master Aug 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-user-drives-endpoint branch August 1, 2022 10:09
ownclouders pushed a commit that referenced this pull request Aug 1, 2022
@dragonchaser
commit c94960c
8acdc12 
Merge: 839f8b3 3212348
Author: Christian Richter <[email protected]>
Date:   Mon Aug 1 12:09:27 2022 +0200

    Merge pull request #4072 from owncloud/fix-user-drives-endpoint

    Add drives output & user filter
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@phil-davis phil-davis Awaiting requested review from phil-davis

@individual-it individual-it Awaiting requested review from individual-it

@kulmann kulmann Awaiting requested review from kulmann

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dragonchaser @ownclouders @phil-davis @micbar