Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] add docs for macOS ulimits #3889

Merged
merged 1 commit into from
May 30, 2022
Merged

[docs-only] add docs for macOS ulimits #3889

merged 1 commit into from
May 30, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented May 30, 2022 •
edited
Loading

Description

add docs for macOS ulimits

Screenshots (if appropriate):

1653907466641

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar
Copy link
Contributor Author

micbar commented May 30, 2022

@mmattel JFYI

fschade
fschade approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one smallish thing, not sure if its critical or not....

ocis || oCIS

expect that, LGTM 🚀

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled...

@pascalwengerter
Copy link
Contributor

Should we open a ticket to track this as technical debt (expecting that this will be handled differently in the future)?

@micbar
Copy link
Contributor Author

micbar commented May 30, 2022

Should we open a ticket to track this as technical debt (expecting that this will be handled differently in the future)?

No, we cannot change that. We have about 30 services running in the oCIS fullstack server. The limits on mac are just too small. This problem does not occur when using docker because that hides it in the docker VM and the container has a running linux which has a default of 1024

@pascalwengerter
Copy link
Contributor

Should we open a ticket to track this as technical debt (expecting that this will be handled differently in the future)?

No, we cannot change that. We have about 30 services running in the oCIS fullstack server. The limits on mac are just too small. This problem does not occur when using docker because that hides it in the docker VM and the container has a running linux which has a default of 1024

Ok, thx for clarification!

@wkloucek wkloucek merged commit d4e0045 into master May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the docs-ulimits branch May 30, 2022 11:58
ownclouders pushed a commit that referenced this pull request May 30, 2022
@wkloucek
commit d4e0045
d899d8b 
Merge: b0f6120 1f5c3b6
Author: Willy Kloucek <[email protected]>
Date:   Mon May 30 13:58:47 2022 +0200

    Merge pull request #3889 from owncloud/docs-ulimits

    [docs-only] add docs for macOS ulimits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@kobergj kobergj Awaiting requested review from kobergj

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@micbar @ownclouders @pascalwengerter @fschade @wkloucek