Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deployments] Enclose boolean with string in docker-compose env #3836

Merged
merged 1 commit into from
May 19, 2022
Merged

[deployments] Enclose boolean with string in docker-compose env #3836

merged 1 commit into from
May 19, 2022

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 19, 2022

Description

docker-compose up inside deployments/examples give this error:

ERROR: The Compose file './docker-compose.yml' is invalid because:
services.ocis.environment.GRAPH_LDAP_INSECURE contains true, which is an invalid type, it should be a string, number, or a null

This PR fixes the error by enclosing boolean value into string.

Motivation and Context

How Has This Been Tested?

  • test environment:

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this May 19, 2022
@update-docs
Copy link

update-docs bot commented May 19, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@saw-jan saw-jan requested a review from wkloucek May 19, 2022 11:11
wkloucek
wkloucek approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 docker-compose v1 seems to be more picky than docker-compose v2

@wkloucek wkloucek merged commit 47b6904 into master May 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-deployment-compose branch May 19, 2022 11:19
ownclouders pushed a commit that referenced this pull request May 19, 2022
@wkloucek
commit 47b6904
9d8275e 
Merge: 8afbb70 ed79a20
Author: Willy Kloucek <[email protected]>
Date:   Thu May 19 13:19:22 2022 +0200

    Merge pull request #3836 from owncloud/fix-deployment-compose

    [deployments] Enclose boolean with string in docker-compose env
@mmattel
Copy link
Contributor

mmattel commented May 20, 2022

This will find its way into the admin docs on the next docs build 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees

@saw-jan saw-jan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saw-jan @mmattel @wkloucek