Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceUser -> SystemUser #3673

Merged
merged 5 commits into from
May 4, 2022
Merged

ServiceUser -> SystemUser #3673

merged 5 commits into from
May 4, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented May 4, 2022

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

kobergj added 2 commits May 4, 2022 11:53
@kobergj
serviceUser -> systemUser
cd6d82c 
Signed-off-by: jkoberg <[email protected]>
@kobergj
changelog
6ce9f76 
Signed-off-by: jkoberg <[email protected]>
@kobergj kobergj mentioned this pull request May 4, 2022
Closed
45 tasks
@ownclouders
Copy link
Contributor

ownclouders commented May 4, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-5 failed. Further test are cancelled...

butonic
butonic suggested changes May 4, 2022
View reviewed changes
extensions/sharing/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
extensions/sharing/pkg/config/config.go Outdated Show resolved Hide resolved
extensions/settings/pkg/config/config.go Outdated Show resolved Hide resolved
@butonic
leave out OCIS_URL, cleanup
080ad7c 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic force-pushed the ServiceUser-to-SystemUser branch from 399f74e to 080ad7c Compare May 4, 2022 11:19
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kobergj kobergj merged commit 25dc46e into owncloud:master May 4, 2022
@kobergj kobergj deleted the ServiceUser-to-SystemUser branch May 4, 2022 14:31
ownclouders pushed a commit that referenced this pull request May 4, 2022
@kobergj
commit 25dc46e
5e459cd 
Author: kobergj <[email protected]>
Date:   Wed May 4 16:31:18 2022 +0200

    ServiceUser -> SystemUser (#3673)

    * serviceUser -> systemUser

    Signed-off-by: jkoberg <[email protected]>

    * changelog

    Signed-off-by: jkoberg <[email protected]>

    * leave out OCIS_URL, cleanup

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    Co-authored-by: Jörn Friedrich Dreyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobergj @ownclouders @butonic