Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load configuration only from one directory #3587

Merged
merged 2 commits into from
Apr 26, 2022
Merged

load configuration only from one directory #3587

merged 2 commits into from
Apr 26, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Apr 26, 2022

Description

We've changed the configuration file loading behavior and are now only loading
configuration files from ONE single directory. This directory can be set on
compile time or via an environment variable on startup (OCIS_CONFIG_DIR).

We are using following configuration default paths:

  • Docker images: /etc/ocis/
  • Binary releases: $HOME/.ocis/config/

Related Issue

Motivation and Context

Make config file loading less confusing for users.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from C0rby and dragonchaser and removed request for phil-davis and individual-it April 26, 2022 10:08
docs/helpers/configenvextractor.go Outdated Show resolved Hide resolved
@wkloucek wkloucek requested a review from dragonchaser April 26, 2022 11:18
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 0f12ffb into owncloud:master Apr 26, 2022
@wkloucek wkloucek deleted the single-config-file-location branch April 26, 2022 13:28
ownclouders pushed a commit that referenced this pull request Apr 26, 2022
Merge: 4b65e6d a915f2e
Author: Willy Kloucek <[email protected]>
Date:   Tue Apr 26 15:28:17 2022 +0200

    Merge pull request #3587 from wkloucek/single-config-file-location

    load configuration only from one directory
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants