Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ocis admin creation for idm #3507

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix ocis admin creation for idm #3507

merged 1 commit into from
Apr 11, 2022

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Apr 11, 2022

The admin user was created as part of the demo user set. But we need the
admin to be created always.

The admin user was created as part of the demo user set. But we need the
admin to be created always.
@update-docs
Copy link

update-docs bot commented Apr 11, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rhafer rhafer requested a review from wkloucek April 11, 2022 14:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel
Copy link
Contributor

mmattel commented Apr 11, 2022

Hooking myself in to get notified when merged, @EParzefall fyi

@mmattel
Copy link
Contributor

mmattel commented Apr 11, 2022

@rhafer pls keep in mind that this will need a change here too (when the LibreIDM part gets finalized):
https://owncloud.dev/ocis/getting-started/demo-users/ (Following users are available in the demo set)

@micbar
Copy link
Contributor

micbar commented Apr 11, 2022

Current text in the docs

To create the demo users, run the inital setup step with an additional environment variable. ACCOUNTS_DEMO_USERS_AND_GROUPS=true ./bin/ocis server will generate the demo users listed in the table below. By default, it only generates the admin and one user for IDP and Reva respectively.

@micbar
Copy link
Contributor

micbar commented Apr 11, 2022

So this is aligned with the described behavior in the dev docs.

@micbar micbar merged commit 4c7eed8 into owncloud:master Apr 11, 2022
ownclouders pushed a commit that referenced this pull request Apr 11, 2022
Merge: 385142f 2a09da2
Author: Michael Barz <[email protected]>
Date:   Mon Apr 11 16:36:01 2022 +0200

    Merge pull request #3507 from rhafer/idmadmin

    Fix ocis admin creation for idm
@mmattel
Copy link
Contributor

mmattel commented Apr 11, 2022

I doubt according the statement in dev docs Following users are available in the demo set: that the admin user is still part of the demo table. An admin user is now created OUTSIDE the demo env variable.
My point was that one must take care that the admin user will not longer be part of the demo users table - I may be wrong...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants