Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Bump core commit id for tests #3473

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Apr 6, 2022

Description

Routine core commit id bump for tests

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@pascalwengerter
Copy link
Contributor

Hasn't this been done 2h ago in #3469?

@SwikritiT
Copy link
Contributor

Hasn't this been done 2h ago in #3469?

Few PRs in core got merged today which changes a lot of lines. So this PR might be for that to adjust the expected to fail. As we are doing a lot of refactoring in core tests, there might be new commit id PR depending on when the PR in core gets merged. I hope that's okay. But we'll try to coordinate so that bumping won't happen within hours.

@pascalwengerter
Copy link
Contributor

Hasn't this been done 2h ago in #3469?

Few PRs in core got merged today which changes a lot of lines. So this PR might be for that to adjust the expected to fail. As we are doing a lot of refactoring in core tests, there might be new commit id PR depending on when the PR in core gets merged. I hope that's okay. But we'll try to coordinate so that bumping won't happen within hours.

Ok cool, just trying to avoid you doing duplicate work here ;) but understandable, go ahead!

@SagarGi SagarGi force-pushed the bump-core-commitid-2022-04-06 branch from 12aff4f to d27b08c Compare April 6, 2022 11:28
@SagarGi SagarGi force-pushed the bump-core-commitid-2022-04-06 branch from d27b08c to d4eb19d Compare April 7, 2022 10:00
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@phil-davis phil-davis merged commit 7303835 into master Apr 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-core-commitid-2022-04-06 branch April 7, 2022 11:30
ownclouders pushed a commit that referenced this pull request Apr 7, 2022
Merge: 7f4b380 d4eb19d
Author: Phil Davis <[email protected]>
Date:   Thu Apr 7 17:15:06 2022 +0545

    Merge pull request #3473 from owncloud/bump-core-commitid-2022-04-06

    [tests-only][full-ci] Bump core commit id for tests
@phil-davis phil-davis mentioned this pull request Apr 7, 2022
9 tasks
@micbar micbar mentioned this pull request Nov 25, 2022
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants