Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default server download protocol if spaces are not supported #3386

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

ishank011
Copy link
Contributor

No description provided.

@ishank011 ishank011 requested review from C0rby, butonic and micbar March 24, 2022 15:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ishank011 ishank011 requested a review from wkloucek March 24, 2022 15:14
@micbar
Copy link
Contributor

micbar commented Mar 24, 2022

@ishank011 can you add a description why this change is needed and what problem does it try to solve?

@ishank011
Copy link
Contributor Author

@micbar this is to enable thumbnails for drivers which don't have spaces implemented and support only either the simple or tus protocols. We have quite a few of those in reva.

@micbar micbar merged commit 1140061 into owncloud:master Mar 30, 2022
ownclouders pushed a commit that referenced this pull request Mar 30, 2022
Merge: cb46d5a 2410032
Author: Michael Barz <[email protected]>
Date:   Wed Mar 30 09:23:48 2022 +0200

    Merge pull request #3386 from ishank011/thumbnails-download-fix

    Use the default server download protocol if spaces are not supported
@ishank011 ishank011 deleted the thumbnails-download-fix branch March 30, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants