support thumbnails in spaces #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 Acceptance test Core-API-Tests-ocis-storage-2 failed. Further test are cancelled... |
C0rby
force-pushed
the
spaces-thumbnails
branch
from
ac7d2dc to
caeb2b6
Compare
|
Kudos, SonarCloud Quality Gate passed! |
butonic
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for thumbnails in spaces.
The thumbnail code in the webdav and thumbnails module feel a bit hacky now after many adjustments.
When we have some more time we should invest a bit of it to make the API of the thumbnails service better.
Maybe even consider a HTTP API for the thumbnails service since serving large content through GRPC is not recommended. (4 MB is already large for GRPC)