Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] Add documemtation for the graph users and group APIs #3149

Merged
merged 1 commit into from
Feb 23, 2022
Merged

[docs-only] Add documemtation for the graph users and group APIs #3149

merged 1 commit into from
Feb 23, 2022

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Feb 10, 2022

No description provided.

@rhafer rhafer self-assigned this Feb 10, 2022
@phil-davis phil-davis changed the title [docs-only] Add documenmtation for the graph users and group APIs [docs-only] Add documemtation for the graph users and group APIs Feb 11, 2022
@rhafer rhafer requested review from kulmann and micbar February 14, 2022 11:30
@rhafer rhafer mentioned this pull request Feb 14, 2022
Closed
@rhafer rhafer requested review from C0rby and wkloucek February 22, 2022 13:48
micbar
micbar approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@rhafer rhafer merged commit 917ae0b into owncloud:master Feb 23, 2022
ownclouders pushed a commit that referenced this pull request Feb 23, 2022
@rhafer
commit 917ae0b
c92dadf 
Merge: 0c67234 5f6bb59
Author: Ralf Haferkamp <[email protected]>
Date:   Wed Feb 23 09:22:46 2022 +0100

    Merge pull request #3149 from rhafer/graph-user-doc

    [docs-only] Add documemtation for the graph users and group APIs
kobergj
kobergj requested changes Feb 23, 2022
View reviewed changes
docs/extensions/graph/groups.md Show resolved Hide resolved
docs/extensions/graph/groups.md
curl -k --request DELETE 'https://localhost:9200/graph/v1.0/groups/7a20f238-8a22-4458-902d-47674c317e5f' -u user:password
```

When successful the API returns no Response Body and the HTTP status code 204 (No Content)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response Body should always be lower case as it is not pointing to a resource

docs/extensions/graph/groups.md

### Removing a member

#### `DELETE /groups/{groupid}/members/{id}/$ret`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Suggested change
#### `DELETE /groups/{groupid}/members/{id}/$ret`
#### `DELETE /groups/{groupid}/members/{id}/$ref`

@rhafer rhafer deleted the graph-user-doc branch February 23, 2022 09:21
@rhafer rhafer mentioned this pull request Feb 23, 2022
Merged
@rhafer
Copy link
Contributor Author

rhafer commented Feb 23, 2022

@kobergj seems I was a little fast with merging this. I've created #3227 to address your feedback. Thanks!

@saw-jan saw-jan mentioned this pull request Jul 4, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj requested changes

@micbar micbar micbar approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@C0rby C0rby Awaiting requested review from C0rby

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees

@rhafer rhafer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rhafer @micbar @kobergj