Delete group memberships when deleting a user #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
suggested changes
Feb 1, 2022
| @@ -182,6 +182,20 @@ func (i *LDAP) DeleteUser(ctx context.Context, nameOrID string) error { | |||
| if err = i.conn.Del(&dr); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| // Find all the groups that this user was a member of and remove it from there | |||
| groupEntries, err := i.getLDAPGroupsByFilter(fmt.Sprintf("(%s=%s)", i.groupAttributeMap.member, e.DN), true, false) | |||
There was a problem hiding this comment.
This error needs to be checked.
Upon deleting a User from the LDAP backend, we also need to cleanup the user's group memberships as LDAP itself doesn't make any promises about referential integrity. Fixes owncloud#3027
rhafer
force-pushed
the
graph-del-user
branch
from
f842f05 to
04083a4
Compare
|
Kudos, SonarCloud Quality Gate passed! |
C0rby
approved these changes
Feb 2, 2022
ownclouders
pushed a commit
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upon deleting a User from the LDAP backend, we also need to cleanup
the user's group memberships as LDAP itself doesn't make any promises
about referential integrity.
Related Issue