Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code smells #3053

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Fix code smells #3053

merged 2 commits into from
Jan 28, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jan 28, 2022

Fixed some code smells pointed out by sonarcloud.

@update-docs
Copy link

update-docs bot commented Jan 28, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

36.8% 36.8% Coverage
0.0% 0.0% Duplication

@C0rby C0rby marked this pull request as ready for review January 28, 2022 13:11
@C0rby C0rby requested review from wkloucek, kobergj and micbar January 28, 2022 13:11
@C0rby C0rby self-assigned this Jan 28, 2022
@wkloucek wkloucek merged commit 4d39225 into master Jan 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-code-smells branch January 28, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@kobergj kobergj Awaiting requested review from kobergj

@micbar micbar Awaiting requested review from micbar

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @wkloucek