Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete loadConfig #3014

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Remove obsolete loadConfig #3014

merged 2 commits into from
Jan 23, 2022

Conversation

dschmidt
Copy link
Member

I did not test this, but grepping for loadConfig, LOAD_CONFIG or simply config I could not find any usage of the app config.

Config handling has been refactored in oC Web, so this code is basically dead.

See owncloud/web#3726

@update-docs
Copy link

update-docs bot commented Jan 22, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise. Let's see if CI turns green

@ownclouders
Copy link
Contributor

💥 Acceptance test settingsUITests failed. Further test are cancelled...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dschmidt
Copy link
Member Author

Thanks!

@dschmidt dschmidt merged commit 60b5a1b into master Jan 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove_loadConfig branch January 23, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants