-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] [full-ci] added breadcrumb issued scenario into the expected failures #2945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can this ever have worked? The acceptance test is ~13 months old
the scenario is only run for the nightly build (not included in the normal builds) you can see the references to failing/passing builds in the related issue |
I thought that we run [full-ci] whenever we update the web commit id, and when we update web into oCIS, and when we update the latest reva into oCIS. So we should have had regular full-ci runs of the web nightwatch tests. I put So why is this only noticed just now? |
6106aa6
to
ff78051
Compare
https://drone.owncloud.com/owncloud/ocis/8652/33/9
That scenario does fail. I suppose it started failing in some "recent" oCIS change that was merged in a PR that did not run full-ci. IMO we need to merge this to get full-ci green, and also look into the issue separately. When the cause of the issue and fix (either to back-end code, web code or test code) is ready, then Adding to expected-failures like this is not ideal. But IMO it is the process that happens when "something" gets into master that causes a test to start failing. |
@kiranparajuli589 please git bisect to find out when it started |
currently blocked due to #2952 (cannot build over past commits) |
ff78051
to
bc64050
Compare
Kudos, SonarCloud Quality Gate passed! |
issue was started from #2739 scenario line addition to the expected failures are already inserted inside https://github.com/owncloud/ocis/pull/2739/files |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: