Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go embed / generate improvements #2815

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 24, 2021

Description

  • simplify embed rule for Web (possible since rename _chunks folder to chunks folder web#5988 landed in Web 4.5.0)
  • add go:generate step to all go:embed steps, so that one can use the go generate ./... command to get all assets
  • don't run go generate ./... anymore in CI, since it is no longer needed (was needed for fileb0x only)

@update-docs
Copy link

update-docs bot commented Nov 24, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek marked this pull request as ready for review November 24, 2021 12:59
@wkloucek wkloucek requested review from C0rby, kobergj and refs and removed request for kulmann and pascalwengerter November 24, 2021 12:59
@wkloucek wkloucek self-assigned this Nov 24, 2021
@wkloucek wkloucek merged commit bc57d13 into master Nov 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the embed-generate-improvements branch November 24, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants