Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no error logging on unsupported files for thumbnailer #2702

Merged
merged 1 commit into from
Oct 29, 2021
Merged

no error logging on unsupported files for thumbnailer #2702

merged 1 commit into from
Oct 29, 2021

Conversation

wkloucek
Copy link
Contributor

Description

Bugfix: Fix error logging when there is no thumbnail for a file

We've fixed the behavior of the logging when there is no thumbnail for a file
(because the filetype is not supported for thumbnail generation).
Previously the WebDAV service always issues an error log in this case. Now, we don't log this event any more.

Related Issue

Motivation and Context

Reduce error logging on production instances, to see real errors.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from C0rby and refs October 29, 2021 06:21
kulmann
kulmann approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce all the noise 🥳 LGTM 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
100.0% 100.0% Duplication

@wkloucek wkloucek merged commit 3e36584 into master Oct 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the no_error_logging_unsupported_thumbnails branch October 29, 2021 07:32
ownclouders pushed a commit that referenced this pull request Oct 29, 2021
@wkloucek
commit 3e36584
d899202 
Merge: d8e2935 3808b29
Author: Willy Kloucek <[email protected]>
Date:   Fri Oct 29 09:32:45 2021 +0200

    Merge pull request #2702 from owncloud/no_error_logging_unsupported_thumbnails

    no error logging on unsupported files for thumbnailer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@kulmann kulmann kulmann approved these changes

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @kulmann @C0rby