Forbid empty password on user creation #2665
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
force-pushed
the
EmptyPassword
branch
from
d08623f to
9f2da29
Compare
💥 Acceptance tests Core-API-Tests-ocis-storage-3 failed. The build is cancelled... |
💥 Acceptance tests Core-API-Tests-ocis-storage-3 failed. The build is cancelled... |
💥 Acceptance tests localApiTests-apiSpaces-ocis failed. The build is cancelled... |
2 similar comments
💥 Acceptance tests localApiTests-apiSpaces-ocis failed. The build is cancelled... |
💥 Acceptance tests localApiTests-apiSpaces-ocis failed. The build is cancelled... |
Only legacy browsers are still supporting this header. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection#browser_compatibility.
The parent directories of the identifier-registration.yaml config file might not exist when starting idp. So instead of creating just the top most directory use MkdirAll to also create the parents.
kobergj
requested review from
individual-it,
kulmann,
micbar,
pascalwengerter and
lookacat
as code owners
|
Kudos, SonarCloud Quality Gate passed! |
|
Closed in favor of #2675 |
💥 Acceptance tests Core-API-Tests-ocis-storage-3 failed. The build is cancelled... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was allowed to create users with empty password
Related Issue
owncloud/product#197
Motivation and Context
Empty passwords are only slightly secure
How Has This Been Tested?
enabled test
Screenshots (if appropriate):
Types of changes
Checklist: