Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated context key #2657

Merged
merged 1 commit into from
Oct 21, 2021
Merged

remove deprecated context key #2657

merged 1 commit into from
Oct 21, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Oct 21, 2021

Description

Removed a deprecated context key from the accounts middleware.

Related Issue

Motivation and Context

Reduce technical debt.

Types of changes

  • Technical debt

Checklist:

  • Code changes

@C0rby C0rby requested review from kulmann and wkloucek October 21, 2021 08:19
@C0rby C0rby self-assigned this Oct 21, 2021
@update-docs
Copy link

update-docs bot commented Oct 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

wkloucek
wkloucek approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@C0rby C0rby merged commit acd2aa3 into master Oct 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-context-key branch October 21, 2021 08:57
ownclouders pushed a commit that referenced this pull request Oct 21, 2021
commit acd2aa3
edbb15f 
Merge: bd8a799 45fe331
Author: David Christofas <[email protected]>
Date:   Thu Oct 21 10:57:43 2021 +0200

    Merge pull request #2657 from owncloud/remove-context-key

    remove deprecated context key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup deprectated UUIDKey
2 participants
@C0rby @wkloucek